Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add -assume-filename option to obtain hint to importer just like google-java-format #65

Merged
merged 1 commit into from May 21, 2022

Conversation

Songmu
Copy link
Contributor

@Songmu Songmu commented May 20, 2022

Added option to accept file paths when input is given from stdin. google-java-format has a similar option.

Copy link
Owner

@nicolascouvrat nicolascouvrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a very minor nit, but otherwise it looks good to me. Thanks for your contribution!

@@ -21,6 +22,8 @@ public class UsageException extends Exception {
" Print the version.",
" --help, -help, -h",
" Print this usage statement.",
" --assume-filename, -assume-filename",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put the option above --fix-only? I'm trying to have options in alphabetical order, with help as the last one.

@nicolascouvrat nicolascouvrat self-requested a review May 21, 2022 19:19
@nicolascouvrat
Copy link
Owner

Let me go ahead and merge that, I plan to add an option soon, I'll sort them then. Thanks again!

@nicolascouvrat nicolascouvrat merged commit 31c21d8 into nicolascouvrat:master May 21, 2022
@Songmu Songmu deleted the assume-filename branch May 21, 2022 22:24
@nicolascouvrat nicolascouvrat added this to the 1.3 milestone May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants