Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds some 3.8 examples #185

Merged
merged 5 commits into from Jan 20, 2020
Merged

Adds some 3.8 examples #185

merged 5 commits into from Jan 20, 2020

Conversation

orta
Copy link
Contributor

@orta orta commented Jan 17, 2020

I need to deploy a version of 3.8 for the playground (vs the nightly builds) but this should be the docs side

@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2020 •
edited

Messages
📖

Deployed to a PR branch

Typos for generateTOC.js

Line Typo
10 s from a given folder and its subfolders. */
112 whatisnew: true
117 whatisnew: true
122 whatisnew: true
141 "Fixits",
165 // Ensure all subfolders are in the sorted section

Typos for Accessibility Modifiers.js

Line Typo
42 super(type
71 const housecat = new Cat();
72 housecat.makeNoise()
75 housecat.type

Typos for Private Class Fields.ts

Line Typo
20 ull name instead of [prefix] [lastname]
23 console.log(`Góðan dag, ${this.#firstName} ${thi
30 eremy = new Person("Jeremy", "Bearimy", "Mr");
41 // keyword in a classfield?" - let's look by making a co
55 oby["_name"] = "Cherny"
Got false positives?

Make changes to the global settings spellcheck.json in /artsy/peril-settings.

Generated by 🚫 dangerJS against 4f49e16

johnnyreilly
johnnyreilly approved these changes Jan 17, 2020
View reviewed changes
Copy link

@johnnyreilly johnnyreilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is one awesome piece of documentation!

@orta orta force-pushed the add_38 branch 2 times, most recently from b02f670 to e1004d7 Compare January 20, 2020 17:34
@orta orta merged commit c0a9725 into master Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyreilly johnnyreilly johnnyreilly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@orta @johnnyreilly