Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lit-html missing when installing web_components #9512

Closed
mbulfair opened this issue Jan 17, 2020 · 5 comments
Closed

lit-html missing when installing web_components #9512

mbulfair opened this issue Jan 17, 2020 · 5 comments

Comments

@mbulfair
Copy link

Describe the bug
When running npx -p @storybook/cli sb init -t web_components

The documentation says some dependencies are installed, but they aren't

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
image

image

Code snippets
npm WARN @storybook/web-components@5.3.6 requires a peer of lit-html@^1.0.0 but none is installed. You must install peer dependencies yourself.
System:

Environment Info:

  System:
    OS: macOS 10.15.2
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
  Binaries:
    Node: 12.13.1 - ~/.nvm/versions/node/v12.13.1/bin/node
    Yarn: 1.10.1 - /usr/local/bin/yarn
    npm: 6.13.6 - ~/.nvm/versions/node/v12.13.1/bin/npm
  Browsers:
    Chrome: 79.0.3945.117
    Firefox: 72.0.1
    Safari: 13.0.4
  npmPackages:
    @storybook/web-components: ^5.3.6 => 5.3.6
  npmGlobalPackages:
    @storybook/cli: 5.3.5
@shilman
Copy link
Member

shilman commented Jan 17, 2020

cc @daKmoR

@daKmoR
Copy link
Contributor

daKmoR commented Jan 17, 2020

I don't really understand? do you want to automatically setup lit-html as a devDependency to the projects?

on storybook it is a peerDependency and that gives you

npm WARN @storybook/web-components@5.3.6 requires a peer of lit-html@^1.0.0 but none is installed. You must install peer dependencies yourself.

which means you have to do that yourself?

is that the step you want to change?

@mbulfair
Copy link
Author

I think my point is the docs that I found say its there, but it's not so if you run the basic install, then start storybook you get an error. I doubt that's the intent is it? I just like clear documentation. Also is this ready? since it's not listed on the main storybook doc site? I'm having issues with mdx docs with my web components as well.

@stale
Copy link

stale bot commented Feb 7, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Feb 7, 2020
@stale
Copy link

stale bot commented Mar 8, 2020

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants